Cap negative values below 0 before quantifying to an unsigned int. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative flux should be prevented, but casting it to an unsigned int will wrap around to MAXINT, which is even worse.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 74.84% 74.83% -0.01%
==========================================
Files 56 56
Lines 7819 7824 +5
==========================================
+ Hits 5852 5855 +3
- Misses 1967 1969 +2 ☔ View full report in Codecov by Sentry. |
|
Most tests pass, good enough. Coverage not, which is correct, but whatever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative flux should be prevented, but casting it to an unsigned int will wrap around to MAXINT, which is even worse.
I'll merge this if the tests pass.